Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete using WindowsRuntime from unit test #899

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Delete using WindowsRuntime from unit test #899

merged 1 commit into from
Sep 21, 2020

Conversation

am11
Copy link
Contributor

@am11 am11 commented Sep 18, 2020

When building the UnitTests profile with .net5.0 (RC2), it gives the following error:

$ cd gui.cs/UnitTests
# bulk update TargetFramework netcoreapp3.1 -> net5.0 (macOS' sed compatible)
$ git ls-files :/*.csproj | xargs -I{} sed -i '' 's/netcoreapp3.1/net5.0/g' {}
# my dotnet 5.0.100-rc.2.20466.16 installation lives in non-standard location
$ ~/.dotnet5/dotnet test -f net5.0

/Users/am11/projects/gui.cs/UnitTests/PosTests.cs(7,38): error CS0234: The type or namespace name 'WindowsRuntime' does not exist in the namespace 'System.Runtime.InteropServices' (are you missing an assembly reference?) [/Users/am11/projects/gui.cs/UnitTests/UnitTests.csproj]

Looks like it was removed in dotnet/runtime#36715 and it is unused in the UnitTests project.

@tig tig merged commit b4b58d7 into gui-cs:master Sep 21, 2020
@am11 am11 deleted the feature/build/net5.0 branch September 21, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@am11 @tig